jiwq commented on a change in pull request #100: SUBMARINE-174. Add travis 
support for K8s submitter
URL: https://github.com/apache/submarine/pull/100#discussion_r349873607
 
 

 ##########
 File path: 
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sJobSubmitter.java
 ##########
 @@ -116,4 +127,43 @@ CustomResourceJobList 
listCustomResourceJobs(K8sJobRequest request) {
     }
     return null;
   }
+
+  @VisibleForTesting
+  void createCustomResourceDefinition(String filePath) {
 
 Review comment:
   Nowadays it's unused, so  I'll remove these methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to