adamantal commented on a change in pull request #63: SUBMARINE-261. Add
exception class in module common utils.
URL: https://github.com/apache/submarine/pull/63#discussion_r352027842
##########
File path:
submarine-client/src/main/java/org/apache/submarine/client/cli/CliUtils.java
##########
@@ -89,24 +89,24 @@ public static void doLoginIfSecure(String keytab, String
principal) throws
if (StringUtils.isEmpty(keytab) || StringUtils.isEmpty(principal)) {
if (StringUtils.isNotEmpty(keytab)) {
- SubmarineRuntimeException e = new SubmarineRuntimeException("The " +
- "parameter of " + CliConstants.PRINCIPAL + " is missing.");
+ SubmarineCliRuntimeException e = new SubmarineCliRuntimeException(
+ "The parameter of " + CliConstants.PRINCIPAL + " is missing.");
LOG.error(e.getMessage(), e);
throw e;
}
if (StringUtils.isNotEmpty(principal)) {
- SubmarineRuntimeException e = new SubmarineRuntimeException("The " +
- "parameter of " + CliConstants.KEYTAB + " is missing.");
+ SubmarineCliRuntimeException e = new SubmarineCliRuntimeException(
+ "The parameter of " + CliConstants.KEYTAB + " is missing.");
Review comment:
```suggestion
String.format("The parameter of %s is missing.",
CliConstants.KEYTAB));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
