adamantal commented on issue #114: SUBMARINE-49 Add more test coverage to RunJobParameters URL: https://github.com/apache/submarine/pull/114#issuecomment-559796164 Hi @jiwq, @liuxunorg. Thanks for explanation. I will refrain myself from working on submarine-client related features in the near future. However it wasn't clear to me what to do with this PR. I'm not making new feature in this, just separated the parameters by responsibility - with the purpose of unit testing. The patch mainly concerns submarine-client, the submarine-server related changes are just the consequence of that, so I cannot really get rid of the submarine-client part of the change. How should I proceed?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
