[
https://issues.apache.org/jira/browse/SUBMARINE-49?focusedWorklogId=353393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353393
]
ASF GitHub Bot logged work on SUBMARINE-49:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/19 10:33
Start Date: 04/Dec/19 10:33
Worklog Time Spent: 10m
Work Description: adamantal commented on pull request #114: SUBMARINE-49
Add more test coverage to RunJobParameters
URL: https://github.com/apache/submarine/pull/114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 353393)
Time Spent: 20m (was: 10m)
> Add more test coverage to RunJobParameters
> ------------------------------------------
>
> Key: SUBMARINE-49
> URL: https://issues.apache.org/jira/browse/SUBMARINE-49
> Project: Apache Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Adam Antal
> Priority: Major
> Labels: pull-request-available
> Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch,
> SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch,
> SUBMARINE-49.005.patch, SUBMARINE-49.006.patch, SUBMARINE-49.007.patch,
> SUBMARINE-49.007.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch,
> SUBMARINE-49.008.patch, SUBMARINE-49.008.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There are some good tests in
> {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but
> these are not testing all fields set by method
> {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}.
>
> Some more extensive testing is needed in this area.
> As an added bonus, the code
> {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}
> could be cleaned up a bit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
