jiwq commented on a change in pull request #117: SUBMARINE-303. Submarine
client submit job to submarine server by grpc.
URL: https://github.com/apache/submarine/pull/117#discussion_r354332766
##########
File path:
submarine-client/src/main/java/org/apache/submarine/client/cli/param/Quicklink.java
##########
@@ -62,15 +62,35 @@ public String getLabel() {
return label;
}
+ public Quicklink setLabel(String label) {
+ this.label = label;
+ return this;
+ }
+
public String getComponentInstanceName() {
return componentInstanceName;
}
+ public Quicklink setComponentInstanceName(String componentInstanceName) {
+ this.componentInstanceName = componentInstanceName;
+ return this;
+ }
+
public String getProtocol() {
return protocol;
}
+ public Quicklink setProtocol(String protocol) {
+ this.protocol = protocol;
+ return this;
+ }
+
public int getPort() {
return port;
}
+
+ public Quicklink setPort(int port) {
+ this.port = port;
+ return this;
Review comment:
Setter should not return a value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
