yuanzac commented on issue #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc. URL: https://github.com/apache/submarine/pull/117#issuecomment-562444082 @jiwq Thanks a lot for the review~ 1. Setter should not return a value. It is used for SubmarineRpcServerProto and ClientProto. Just like a builder, with a return value. we can make the conversion between JOBO and protobuf object more concisely. 2. Should create the common-rpc and server-rpc module? In my opinion, it is not required. The RPC server belongs to the submarine server. Since commons-rpc depends on protobuf 3.*, which is incompatible with hadoop protobuf 2.*. We'd better use a seperate module and shade the dependency to avoid jar conflicts. 3. The PB is related to the Generic Job Spec, you'd better create a JIRA ticket to tracking this. This PR doesn't make Generic Job Spec modifications. Zhankun is working on it and it'll be a seperated JIRA.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
