[
https://issues.apache.org/jira/browse/SUBMARINE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhankun Tang updated SUBMARINE-79:
----------------------------------
Component/s: Commons
Target Version: 0.4.0
> Cleanup MockRemoteDirectoryManager
> ----------------------------------
>
> Key: SUBMARINE-79
> URL: https://issues.apache.org/jira/browse/SUBMARINE-79
> Project: Apache Submarine
> Issue Type: Improvement
> Components: Commons
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
>
> Many methods in MockRemoteDirectoryManager are declaring unnecessary throws
> clause for IOException.
> Also, there are 2 dangerous NPE candidates:
> 1. MockRemoteDirectoryManager#getJobStagingArea:
> {code:java}
> this.jobDir = new File(jobsParentDir.getAbsolutePath(), jobName);
> {code}
> If jobsParentDir is null, we could have an NPE easily.
> 2. MockRemoteDirectoryManager#getModelDir:
> {code:java}
> File modelDir = new File(modelParentDir.getAbsolutePath(), modelName);
> {code}
> If modelParentDir is null, we could have an NPE easily.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
