[ 
https://issues.apache.org/jira/browse/SUBMARINE-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhankun Tang resolved SUBMARINE-48.
-----------------------------------
    Fix Version/s: 0.3.0
       Resolution: Fixed

Let's resolve this for now. Submarine now is using below formats although 
different with the design doc:
--env DOCKER_JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64/jre/ \
--env DOCKER_HADOOP_HDFS_HOME=/app/hadoop-3.2.1 \
--env HADOOP_HOME=/hadoop-3.2.1 \
--env HADOOP_YARN_HOME=/hadoop-3.2.1 \
--env HADOOP_COMMON_HOME=/hadoop-3.2.1 \
--env HADOOP_HDFS_HOME=/hadoop-3.2.1 \
--env HADOOP_CONF_DIR=/hadoop-3.2.1/etc/hadoop \

> Format of env vars job run parameter is not documented
> ------------------------------------------------------
>
>                 Key: SUBMARINE-48
>                 URL: https://issues.apache.org/jira/browse/SUBMARINE-48
>             Project: Apache Submarine
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>             Fix For: 0.3.0
>
>
> According to the Submarine design doc 
> ([https://docs.google.com/document/d/199J4pB3blqgV9SCNvBbTqkEoQdjoyGMjESV4MktCo0k/edit#heading=h.klmv5hrbgx9l),]
>  the environment variables are passed like this to job run: 
> {code:java}
> --envs key1=value1,key2=value2
> {code}
> However, this is not straightforward from reading the code and it's not 
> documented in 
> {{org.apache.hadoop.yarn.submarine.client.cli.RunJobCli#generateOptions}}, so 
> users won't see it straight away when executing the help command. 
> We need to fix this.
> Some unit tests are also need to be added, as testing envs is not covered at 
> all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to