tangzhankun commented on issue #130: SUBMARINE-321. Add JobManager and SubmitterManager components URL: https://github.com/apache/submarine/pull/130#issuecomment-566830915 Thanks a lot! Wanqiang! The patch looks good to me. Do we need to add simple test cases? Or we can add in following patch. Another question is do we need to add default values explicitly in submarine-site.xml? Maybe we can add that later too.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
