tangzhankun commented on a change in pull request #132: SUBMARINE-296 [SDK]
Submarine pipeline example
URL: https://github.com/apache/submarine/pull/132#discussion_r361043839
##########
File path: submarine-sdk/pysubmarine/example/deepFM.json
##########
@@ -0,0 +1,31 @@
+{
+ "input": {
+ "train_data": "./data/tr.libsvm",
Review comment:
Thanks for your contribution! @pingsutw It looks good to me. One minor
suggestion, can we use the hyphen instead of underscore? The underscore
character seems more preferred from a developer view and is not user-friendly
to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
