liuxunorg commented on a change in pull request #138: SUBMARINE-326. Hook
submarine REST server and JobManager to accept K8s Tensorflow Job
URL: https://github.com/apache/submarine/pull/138#discussion_r362303923
##########
File path:
submarine-server/server-api/src/main/java/org/apache/submarine/server/api/job/JobId.java
##########
@@ -43,6 +48,25 @@ public static JobId newInstance(long serverTimestamp, int
id) {
return jobId;
}
+ /**
+ * Get the object of JobId.
+ * @param jobIdString job id string
+ * @return object
+ */
+ public static JobId newInstance(String jobIdString) {
Review comment:
Change `jobIdString` to `id`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
