jiwq commented on a change in pull request #143: SUBMARINE-333. Docs of submarine server deployment URL: https://github.com/apache/submarine/pull/143#discussion_r365820134
########## File path: dev-support/k8s/tfjob/operator/service.yaml ########## @@ -0,0 +1,19 @@ +--- +apiVersion: v1 +kind: Service +metadata: + annotations: + prometheus.io/path: /metrics + prometheus.io/scrape: "true" + prometheus.io/port: "8443" Review comment: Annotations is an unstructured key value map stored with a resource that may be set by external tools to store and retrieve arbitrary metadata. For more info see https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/ So the user doesn't need to setup prometheus. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
