liuxunorg commented on a change in pull request #151: [Submarine-339] Separate 
SubmarineConfVars from SubmarineConfiguration
URL: https://github.com/apache/submarine/pull/151#discussion_r366122248
 
 

 ##########
 File path: 
submarine-commons/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
 ##########
 @@ -480,8 +481,8 @@ public boolean getBoolean(String envName, String 
propertyName, boolean defaultVa
   public void updateConfiguration(String name, String value) {
     properties.put(name, value);
   }
-
-  public enum ConfVars {
+/*
+  public enum SubmarineConfVars {
 
 Review comment:
   Can you delete `public enum SubmarineConfVars {....}` code block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to