liuxunorg commented on a change in pull request #158: SUBMARINE-349. Support
using existing artifacts to build mini-submarine image
URL: https://github.com/apache/submarine/pull/158#discussion_r369064306
##########
File path: dev-support/mini-submarine/build_mini-submarine.sh
##########
@@ -13,10 +13,16 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-
+set -e
hadoop_v=2.9.2
spark_v=2.4.4
-submarine_v=0.3.0-SNAPSHOT
+
+submarine_v=$submarine_version
Review comment:
submarine_v =${submarine_version:-"0.3.0-SNAPSHOT"}
This way, So you can set default values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
