pingsutw commented on a change in pull request #161: SUBMARINE-356.
ParameterProto should support getOptionValue method
URL: https://github.com/apache/submarine/pull/161#discussion_r369359011
##########
File path:
submarine-server/server-rpc/src/main/java/org/apache/submarine/server/rpc/SubmarineRpcServerProto.java
##########
@@ -63,9 +72,70 @@ public static Parameter convertParameterProtoToParameter(
} else if (parameterProto.hasShowJobParameter()) {
parameter = convertParameterProtoToShowJob(parameterProto);
}
+ setCommandLineYamlConfigIfNeeded(parameter, parameterProto);
return parameter;
}
+ public static void setCommandLineYamlConfigIfNeeded(
+ Parameter parameter, ParameterProto parameterProto) {
+ if(parameter instanceof ParametersHolder) {
+ ParametersHolder parametersHolder = ((ParametersHolder) parameter);
+ CommandLine commandLine = convertCommandLineProtoToCommandLine(
+ parameterProto.getCommandLine());
+ parametersHolder.setparsedCommandLine(commandLine);
Review comment:
`setparsedCommandLine` need to rename to `setParsedCommandLine`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
