yuanzac commented on a change in pull request #180: SUBMARINE-379. Delete
invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#discussion_r377483473
##########
File path: pom.xml
##########
@@ -441,10 +441,6 @@
<goals>
<goal>check</goal>
</goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
Review comment:
Do we need to delete this line? line 428 is like to set failOnViolation to
false.
How about we just delete
<excludes>com/linkedin/tony/rpc/proto/*,com/linkedin/tony/events/*</excludes>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
