kevin85421 commented on a change in pull request #186: SUBMARINE-383.
Implement frontend of workspace in workbench server with Angular
URL: https://github.com/apache/submarine/pull/186#discussion_r380039679
##########
File path:
submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.module.ts
##########
@@ -38,13 +46,20 @@ import { WorkspaceComponent } from
'./workspace/workspace.component';
InterpreterComponent,
JobComponent,
DataComponent,
- ModelComponent
+ ModelComponent,
+ ProjectComponent,
+ ReleaseComponent,
+ TrainingComponent,
+ TeamComponent,
+ SharedComponent,
+ NewProjectPageComponent
Review comment:
Do these components be used only in the Workspace? If so, we can declare
these components with nested hierarchy, a more private method, to protect these
components from being accessed by other components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
