yanboliang commented on a change in pull request #132: SUBMARINE-296. [SDK] 
Submarine pipeline example
URL: https://github.com/apache/submarine/pull/132#discussion_r380495415
 
 

 ##########
 File path: submarine-sdk/pysubmarine/example/deepFM.json
 ##########
 @@ -0,0 +1,31 @@
+{
 
 Review comment:
   I would suggest to organize the structure in the following way:
   * submarine-sdk/pysubmarine/example/deepFM/run_deepFM.py  // Entry point
   * submarine-sdk/pysubmarine/example/deepFM/deepFM.json  // Configuration
   * submarine-sdk/pysubmarine/example/data/deepFM/***.libsvm // Data
   
   We can follow this structure to add more models/workflows. 
```submarine-sdk/pysubmarine/example/data``` can be mapped to HDFS and then 
users can directly access the data via HDFS API.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to