cchung100m opened a new pull request #223: SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager URL: https://github.com/apache/submarine/pull/223 ### What is this PR for? Solve potential NPE for MockRemoteDirectoryManager MockRemoteDirectoryManager#getModelDir: `File modelDir = new File(modelParentDir.getAbsolutePath(), modelName);` If modelParentDir is null, we could have an NPE easily. ### What type of PR is it? [Bug Fix | Improvement ] ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-79 ### How should this be tested? https://travis-ci.com/cchung100m/submarine/builds/152619875 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
