pingsutw commented on a change in pull request #226: SUBMARINE-84. Set random
port in TF_CONFIG
URL: https://github.com/apache/submarine/pull/226#discussion_r392250288
##########
File path:
submarine-server/server-submitter/submitter-yarnservice/src/main/java/org/apache/submarine/server/submitter/yarnservice/tensorflow/TensorFlowConfigEnvGenerator.java
##########
@@ -19,15 +19,18 @@
package org.apache.submarine.server.submitter.yarnservice.tensorflow;
+import java.io.IOException;
+import org.apache.hadoop.net.ServerSocketUtil;
import org.apache.submarine.commons.runtime.conf.Envs;
import org.apache.submarine.server.submitter.yarnservice.YarnServiceUtils;
public class TensorFlowConfigEnvGenerator {
public static String getTFConfigEnv(String componentName, int nWorkers,
- int nPs, String serviceName, String userName, String domain) {
+ int nPs, String serviceName, String userName, String domain) throws
IOException {
String commonEndpointSuffix = YarnServiceUtils
- .getDNSNameCommonSuffix(serviceName, userName, domain, 8000);
+ .getDNSNameCommonSuffix(serviceName, userName, domain,
Review comment:
https://github.com/apache/submarine/blob/ebad135c1e44bc75f76c41fbaaeece87ed65d144/submarine-server/server-submitter/submitter-yarnservice/src/main/java/org/apache/submarine/server/submitter/yarnservice/YarnServiceJobSubmitter.java#L103-L114
@yuanzac, @liuxunorg
since we use Yarn Service to submit the job, we couldn't control NM behavior.
so that we couldn't generate port in the NM node.
Please correct me if I'm wrong.
Maybe we could just close this pr since yarn service runtime is deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
