[
https://issues.apache.org/jira/browse/SUBMARINE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhankun Tang resolved SUBMARINE-429.
------------------------------------
Fix Version/s: 0.4.0
Resolution: Fixed
Issue resolved by pull request 228
[https://github.com/apache/submarine/pull/228]
> Fix conflicts of java indentation between ".editorconfig" and mvn checkstyle
> plugin
> -----------------------------------------------------------------------------------
>
> Key: SUBMARINE-429
> URL: https://issues.apache.org/jira/browse/SUBMARINE-429
> Project: Apache Submarine
> Issue Type: Bug
> Components: CI/CD
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
> Fix For: 0.4.0
>
>
> The ".editorconfig" enforced all the java indent size to 2 which will cause
> conflicts when maven check-style plugin does checking.
> [https://github.com/apache/submarine/commit/e3b5c5cda9c8cc59ddc8a2406fac4211c68b17cf]
> Since we have a more flexible check setting in the maven plugin. I suggest
> that we remove the java/scala style definition in ".editorconfig".
> Or if possible, we can provide different editor's configuration to enforce
> language style when using the recommended IDE.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
