This is an automated email from the ASF dual-hosted git repository.
jiwq pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new b572063 SUBMARINE-497. [WEB] Fix typo in data Component
b572063 is described below
commit b5720635fa6c23d1e3df028c0cd8ff9671e4d7c1
Author: flirmnave <[email protected]>
AuthorDate: Tue May 12 22:16:50 2020 +0800
SUBMARINE-497. [WEB] Fix typo in data Component
### What is this PR for?
Fix typo in data Component.
**columnDelimeter** change to **columnDelimiter**
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-497
### How should this be tested?
* First time? Setup Travis CI as described on
https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed
behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? Yes/No
* Is there breaking changes for older versions? Yes/No
* Does this needs documentation? Yes/No
Author: flirmnave <[email protected]>
Closes #288 from flirmnave/SUBMARINE-497 and squashes the following commits:
58b8764 [flirmnave] SUBMARINE-497. [WEB] Fix typo in data Component
---
.../workbench-web-ng/src/app/pages/workbench/data/data.component.html | 4 ++--
.../workbench-web-ng/src/app/pages/workbench/data/data.component.ts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.html
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.html
index efb9101..455f892 100644
---
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.html
+++
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.html
@@ -170,12 +170,12 @@
</div>
<div>
<label class="form-label"><span class="red-star">* </span>
Column Delimiter:</label>
- <input type="text" style="width: 50px;margin-top: 25px;"
nz-input class="form-control" formControlName="columnDelimeter" />
+ <input type="text" style="width: 50px;margin-top: 25px;"
nz-input class="form-control" formControlName="columnDelimiter" />
<label nz-checkbox style="margin-left: 20px;"
class="form-control" formControlName="header">First row is header</label>
</div>
</div>
<div style="margin-top: 32px;text-align: center;">
- <button id="firstNextBtn" nz-button nzType="primary"
[disabled]="!createTable.get('columnDelimeter').valid" (click)="newTablePage =
newTablePage + 1">Create Table with UI </button>
+ <button id="firstNextBtn" nz-button nzType="primary"
[disabled]="!createTable.get('columnDelimiter').valid" (click)="newTablePage =
newTablePage + 1">Create Table with UI </button>
<button style="margin-left: 5px;" nz-button nzType="default"
[disabled]="true" (click)="openNotebook()">Create Table in Notebook </button>
</div>
</div>
diff --git
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.ts
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.ts
index bf05996..61ce83c 100644
---
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.ts
+++
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/data/data.component.ts
@@ -67,7 +67,7 @@ export class DataComponent implements OnInit {
'path': new FormControl(null),
'uploadFile': new FormControl(null),
'fileType': new FormControl(null),
- 'columnDelimeter': new FormControl('.', [Validators.required]),
+ 'columnDelimiter': new FormControl('.', [Validators.required]),
'header': new FormControl('false'),
'dataBaseName': new FormControl('db1'),
@@ -170,7 +170,7 @@ export class DataComponent implements OnInit {
'path': new FormControl(null),
'uploadFile': new FormControl(null),
'fileType': new FormControl(null),
- 'columnDelimeter': new FormControl('.', [Validators.required]),
+ 'columnDelimiter': new FormControl('.', [Validators.required]),
'header': new FormControl('false'),
'dataBaseName': new FormControl('db1'),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
