[ 
https://issues.apache.org/jira/browse/SUBMARINE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116299#comment-17116299
 ] 

Wangda Tan commented on SUBMARINE-507:
--------------------------------------

Thanks [[email protected]], 

I just took a brief look at the patch, have some questions: 

1) is this patch on top of the SUBMARINE-506? 

2) We need to make sure the patch is using the same swagger framework.

3) How about persistent storage of the environment metadata? It should be 
similar to the experiment APIs. 

4) I think for now we don't have to include VM Image field till we can support 
it. 

Also for the Jira: 

1) Can you include the description of the problem you want to solve? 

2) It looks like filing one Jira for each C/R/U/D seems overkill, we should 
have a good API definition for these basic operations first. 

Adding [~tangzhankun], [~pingsutw] to help with patch review. 

> [Umbrella] Submarine Environment Management
> -------------------------------------------
>
>                 Key: SUBMARINE-507
>                 URL: https://issues.apache.org/jira/browse/SUBMARINE-507
>             Project: Apache Submarine
>          Issue Type: New Feature
>            Reporter: Manikandan R
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to