This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 4f8e889  SUBMARINE-515. [WEB]Implement Hyper parameters in experiment 
page.
4f8e889 is described below

commit 4f8e889a09b92ec38916c9aba0ec19cf9eb54d64
Author: chiajoukuo <[email protected]>
AuthorDate: Tue Jun 23 18:41:18 2020 +0800

    SUBMARINE-515. [WEB]Implement Hyper parameters in experiment page.
    
    ### What is this PR for?
    Implement Hyper parameters in experiment page.
    
    ### What type of PR is it?
    [Feature]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-515
    
    ### How should this be tested?
    https://travis-ci.org/github/apache/submarine/builds/701222351
    
    ### Screenshots (if appropriate)
    ![螢幕錄製-2020-06-23-下午12 37 
39](https://user-images.githubusercontent.com/45503025/85362948-5965a200-b552-11ea-94b4-6252bef6a00d.gif)
    
    ### Questions:
    * Does the licenses files need update? Yes/No
    * Is there breaking changes for older versions? Yes/No
    * Does this needs documentation? Yes/No
    
    Author: chiajoukuo <[email protected]>
    
    Closes #324 from chiajoukuo/SUBMARINE-515 and squashes the following 
commits:
    
    dc62738 [chiajoukuo] fix code style
    f9070b1 [chiajoukuo] bugfix
    e9fe74b [chiajoukuo] Implement Hyper parameters in experiment page.
---
 .../apache/submarine/integration/experimentIT.java |  4 +++
 .../hyper-params/hyper-params.component.html       | 15 ++++++++-
 .../hyper-params/hyper-params.component.ts         | 37 +++++++++++++++++++++-
 3 files changed, 54 insertions(+), 2 deletions(-)

diff --git 
a/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
 
b/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
index 98e47b7..334108e 100644
--- 
a/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
+++ 
b/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
@@ -26,6 +26,8 @@ import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 import org.testng.Assert;
+import org.openqa.selenium.support.ui.WebDriverWait;
+import org.openqa.selenium.support.ui.ExpectedConditions;
 
 public class experimentIT extends AbstractSubmarineIT {
 
@@ -58,6 +60,8 @@ public class experimentIT extends AbstractSubmarineIT {
     // Test create new experiment
     pollingWait(By.xpath("//button[@id='openExperiment']"), 
MAX_BROWSER_TIMEOUT_SEC).click();
     Assert.assertTrue(pollingWait(By.xpath("//form"), 
MAX_BROWSER_TIMEOUT_SEC).isDisplayed());
+    WebDriverWait wait = new WebDriverWait( driver, 60);
+    
wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("//label[contains(text(),
 \"Experiment Name\")]")));
     pollingWait(By.xpath("//input[@id='experimentName']"), 
MAX_BROWSER_TIMEOUT_SEC).sendKeys("e2e test Experiment");
     pollingWait(By.xpath("//textarea"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("e2e 
test Project description");
     pollingWait(By.xpath("//button[@id='go']"), 
MAX_BROWSER_TIMEOUT_SEC).click();
diff --git 
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.html
 
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.html
index 6d1c637..083eaec 100644
--- 
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.html
+++ 
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.html
@@ -17,4 +17,17 @@
   ~ under the License.
   -->
 
-<p>hyper-params works!</p>
+<nz-table #basicTable [nzFrontPagination]="false" [nzData]="paramsList">
+  <thead>
+    <tr>
+      <th>Key</th>
+      <th>Value</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr *ngFor="let data of basicTable.data">
+      <td>{{ data.key }}</td>
+      <td>{{ data.value }}</td>
+    </tr>
+  </tbody>
+</nz-table>
diff --git 
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.ts
 
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.ts
index a6df963..4f99656 100644
--- 
a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.ts
+++ 
b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.ts
@@ -19,13 +19,48 @@
 
 import { Component, OnInit } from '@angular/core';
 
+interface HyperParams {
+  key: string;
+  value: string;
+}
+
 @Component({
   selector: 'submarine-hyper-params',
   templateUrl: './hyper-params.component.html',
   styleUrls: ['./hyper-params.component.scss']
 })
 export class HyperParamsComponent implements OnInit {
+  paramsList: HyperParams[] = [];
+
   constructor() {}
 
-  ngOnInit() {}
+  ngOnInit() {
+    // TODO(chiajoukuo): get data from server
+    this.paramsList = [
+      {
+        key: 'conf',
+        value: '/var/tf_deepfm/deepfm.json'
+      },
+      {
+        key: 'train_beta1',
+        value: '0.9'
+      },
+      {
+        key: 'train_beta2',
+        value: '0.999'
+      },
+      {
+        key: 'train_epsilon',
+        value: '1.0E-8'
+      },
+      {
+        key: 'train_lr',
+        value: '5.0E-4'
+      },
+      {
+        key: 'train_Optimizer',
+        value: 'AdamOptimizer'
+      }
+    ];
+  }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to