This is an automated email from the ASF dual-hosted git repository.
jiwq pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 89cb8f6 SUBMARINE-612. Environment variable not found in jupyter pod
89cb8f6 is described below
commit 89cb8f65a32bd085bbc364845f2f748ec14a0280
Author: Ryan Lo <[email protected]>
AuthorDate: Tue Sep 1 02:27:25 2020 +0800
SUBMARINE-612. Environment variable not found in jupyter pod
### What is this PR for?
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java#L81
it should be " if (notebookPodSpec.getEnvVars() != null)"
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[SUBMARINE-612](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-612)
### How should this be tested?
[travis
ci](https://travis-ci.org/github/lowc1012/submarine/builds/723505973)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Ryan Lo <[email protected]>
Closes #392 from lowc1012/SUBMARINE-612 and squashes the following commits:
13e47ab [Ryan Lo] SUBMARINE-612. Environment variable not found in jupyter
pod
---
.../submarine/server/submitter/k8s/parser/NotebookSpecParser.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java
b/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java
index e606688..9cd7d31 100644
---
a/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java
+++
b/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java
@@ -78,7 +78,7 @@ public class NotebookSpecParser {
container.setName(notebookSpec.getMeta().getName());
// Environment variables
- if (notebookPodSpec.getEnvVars() == null) {
+ if (notebookPodSpec.getEnvVars() != null) {
container.setEnv(parseEnvVars(notebookPodSpec));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
