Kai-Hsun Chen created SUBMARINE-841:
---------------------------------------

             Summary: Modify hard-coded URLs in frontend E2E test to soft-coded 
URLs
                 Key: SUBMARINE-841
                 URL: https://issues.apache.org/jira/browse/SUBMARINE-841
             Project: Apache Submarine
          Issue Type: Improvement
          Components: Cloud-native Deployment, E2E Test
            Reporter: Kai-Hsun Chen
            Assignee: Kai-Hsun Chen
             Fix For: 0.6.0


Currently, some frontend E2E tests determine whether a test passes or fails 
based on a hard-coded URL and port. 

 

Take 
[dataIT|https://github.com/apache/submarine/blob/master/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/dataIT.java#L60]
 as an example, the following code hard-coded the expected URL to 
"http://localhost:8080/workbench/data";. However, we cannot ensure that 
Submarine Workbench will always run on "http://localhost:8080";. Hence, this 
issue aims to change the hard-coded URL to a soft-coded URL.

 
{code:java}
Assert.assertEquals(driver.getCurrentUrl(),"http://localhost:8080/workbench/data";);{code}
 

 

Hardcoding vs Softcoding: [https://simplicable.com/new/hardcoding-vs-softcoding]

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to