This is an automated email from the ASF dual-hosted git repository.
kuanhsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 40c8166 SUBMARINE-1154. Add pytorchjobs/finalizers and
tfjobs/finalizers resources RBAC
40c8166 is described below
commit 40c8166a0a9a8c61926e54190346855c8b6b0147
Author: cdmikechen <[email protected]>
AuthorDate: Tue Dec 21 16:46:42 2021 +0800
SUBMARINE-1154. Add pytorchjobs/finalizers and tfjobs/finalizers resources
RBAC
### What is this PR for?
Add pytorchjobs/finalizers and tfjobs/finalizers resources to fix the
problem that the experiment pod cannot be created normally
### What type of PR is it?
Bug Fix
### Todos
* [x] - Add pytorchjobs/finalizers and tfjobs/finalizers resources RBAC
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1154
### How should this be tested?
After the CRD is created, we can check whether the pod starts normally.
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: cdmikechen <[email protected]>
Signed-off-by: kuanhsun <[email protected]>
Closes #846 from cdmikechen/SUBMARINE-1154 and squashes the following
commits:
cac64739 [cdmikechen] SUBMARINE-1154. Add pytorchjobs/finalizers and
tfjobs/finalizers resources RBAC
---
helm-charts/submarine/charts/pytorchjob/templates/rbac.yaml | 1 +
helm-charts/submarine/charts/tfjob/templates/cluster-role.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/helm-charts/submarine/charts/pytorchjob/templates/rbac.yaml
b/helm-charts/submarine/charts/pytorchjob/templates/rbac.yaml
index 0917040..21f5346 100644
--- a/helm-charts/submarine/charts/pytorchjob/templates/rbac.yaml
+++ b/helm-charts/submarine/charts/pytorchjob/templates/rbac.yaml
@@ -34,6 +34,7 @@ rules:
resources:
- pytorchjobs
- pytorchjobs/status
+ - pytorchjobs/finalizers
verbs:
- '*'
- apiGroups:
diff --git a/helm-charts/submarine/charts/tfjob/templates/cluster-role.yaml
b/helm-charts/submarine/charts/tfjob/templates/cluster-role.yaml
index 2620ca9..17c26a2 100644
--- a/helm-charts/submarine/charts/tfjob/templates/cluster-role.yaml
+++ b/helm-charts/submarine/charts/tfjob/templates/cluster-role.yaml
@@ -27,6 +27,7 @@ rules:
resources:
- tfjobs
- tfjobs/status
+ - tfjobs/finalizers
verbs:
- '*'
- apiGroups:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
