This is an automated email from the ASF dual-hosted git repository.
cdmikechen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new d676b46c SUBMARINE-1335. Fix jira version filter exception
d676b46c is described below
commit d676b46c64de00adb96f08f8a491c5c628458d32
Author: cdmikechen <cdmikec...@apache.org>
AuthorDate: Tue Oct 4 19:32:59 2022 +0800
SUBMARINE-1335. Fix jira version filter exception
### What is this PR for?
The filter that currently handles version information within the merge pr
code is not converted to a list, which can lead to errors later in the
processing of versions.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Add `list()` to filter
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1335
### How should this be tested?
No.
### Screenshots (if appropriate)
No.
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: cdmikechen <cdmikec...@apache.org>
Signed-off-by: cdmikechen <cdmikec...@apache.org>
Closes #1002 from cdmikechen/SUBMARINE-1335 and squashes the following
commits:
bfc7a583 [cdmikechen] Fix jira version filter exception
---
dev-support/cicd/merge_submarine_pr.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev-support/cicd/merge_submarine_pr.py
b/dev-support/cicd/merge_submarine_pr.py
index 03979e3c..4f9b944b 100755
--- a/dev-support/cicd/merge_submarine_pr.py
+++ b/dev-support/cicd/merge_submarine_pr.py
@@ -255,9 +255,9 @@ def resolve_jira_issue(merge_branches, comment,
default_jira_id=""):
versions = asf_jira.project_versions("SUBMARINE")
versions = sorted(versions, key=lambda x: x.name, reverse=True)
- versions = filter(lambda x: x.raw["released"] is False, versions)
+ versions = list(filter(lambda x: x.raw["released"] is False, versions))
# Consider only x.y.z versions
- versions = filter(lambda x: re.match(r"\d+\.\d+\.\d+", x.name), versions)
+ versions = list(filter(lambda x: re.match(r"\d+\.\d+\.\d+", x.name),
versions))
default_fix_versions: List = list(
map(lambda x: fix_version_from_branch(x, list(versions)).name,
merge_branches)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org
