C. Michael Pilato wrote: > Patch looks good. +1 to commit. Committed revision 881710.
Thanks. - Julian > Julian Foad wrote: > > C. Michael Pilato wrote: > >> I think there might be some parts that are incorrect. For example: > >> > >> - (HEADER PROP-KEY DATA-KEY [EDIT-DATA-KEY]) > >> + (HEADER PROP-KEY DATA-KEY [DATA-KEY-UNIQID] [EDIT-DATA-KEY]) > >> > >> If you look at the faux BNF stuff at the end, I think you'll find that we > >> didn't squeeze a new atom DATA-KEY-UNIQID into the skel -- we made DATA-KEY > >> be either an atom (for compat with old repositories) or a 2-tuple > >> `(DATA-KEY > >> DATA-KEY-UNIQID)'. > > > > Heh, saw that, tried to write an informal equivalent for the purposes of > > this descriptive part of the document, as some other examples were > > informal (omitting square brackets that would denote optionality) but I > > don't fully grasp the syntax yet and I'll admit that was a misleading > > thing to do. I will write it formally, as: > > > > [[[ > > (HEADER PROP-KEY DATA-INFO [EDIT-DATA-KEY]) > > > > where > > > > DATA-INFO ::= DATA-KEY | (DATA-KEY DATA-KEY-UNIQID) > > > > and DATA-KEY identifies the representation for [...] > > ]]] > > > > I have also found and formalized two or three more instances where > > definitions were informally abbreviated. [...]
