On Mon, 23 Nov 2009, Arfrever Frehtes Taifersar Arahesis wrote:

2009-11-23 02:46:14 Martin Furter napisa??(a):

[[[
The options -mindepth and -maxdepth of find are not portable.
Since there aren't any other python files in subversion/tests/ except
those at depth 2 and 3 just drop those options.

Searching for *.pyc files in svn-test-work directory might significantly
decrease performance...

https://svn.apache.org/viewvc?view=revision&revision=878872

* Makefile.in
   (fast-clean): Remove -mindepth and -maxdepth from find command.
]]]

OK, what about this approach:

[[[
The options -mindepth and -maxdepth of find are not portable.
So do it without using find.

* Makefile.in
  (fast-clean): Use shell wildcards instead of find.
]]]


[[[
Index: Makefile.in
===================================================================
--- Makefile.in (revision 883010)
+++ Makefile.in (working copy)
@@ -369,8 +369,8 @@
        rm -f $(CLEAN_FILES)
        find $(CTYPES_PYTHON_SRC_DIR) $(SWIG_PY_SRC_DIR) $(SWIG_PY_DIR) \
                $(abs_srcdir)/build -name "*.pyc" -exec rm {} ';'
-       find $(abs_srcdir)/subversion/tests/ -mindepth 2 -maxdepth 3 \
-               -name "*.pyc" -exec rm {} ';'
+       rm -f $(abs_srcdir)/subversion/tests/*/*.pyc
+       rm -f $(abs_srcdir)/subversion/tests/*/*/*.pyc

 # clean all but bulky test output, returning to before './configure' was run.
 SVN_CONFIG_SCRIPT_FILES = @SVN_CONFIG_SCRIPT_FILES@
]]]

Reply via email to