> -----Original Message-----
> From: i...@apache.org [mailto:i...@apache.org]
> Sent: zaterdag 21 november 2009 10:40
> To: comm...@subversion.apache.org
> Subject: svn commit: r882999 -
> /subversion/trunk/build/generator/gen_win.py
> 
> Author: ivan
> Date: Sat Nov 21 21:40:05 2009
> New Revision: 882999
> 
> URL: http://svn.apache.org/viewvc?rev=882999&view=rev
> Log:
> Follow-up to r882679: Fix Windows build.
> 
> * build/generator/gen_win.py
>   (_create_sqlite_headers): Add libsvn_fs_fs/revprops-db.sql to the SQL
>    sources list.

        Hyrum,

I think you should also add this file to build.conf in the "CONSTRUCTED 
HEADERS" section, to allow regenerating it from make/Visual Studio instead of 
only from gen-make, like the other .sql files.

BTW. It would be nice if we could retrieve this list in gen_win.py from that 
list in build.conf, instead of duplicating the info.

        Bert

> 
> 
> Modified:
>     subversion/trunk/build/generator/gen_win.py
> 
> Modified: subversion/trunk/build/generator/gen_win.py
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_win.p
> y?rev=882999&r1=882998&r2=882999&view=diff
> =======================================================================
> =======
> --- subversion/trunk/build/generator/gen_win.py (original)
> +++ subversion/trunk/build/generator/gen_win.py Sat Nov 21 21:40:05
> 2009
> @@ -1486,6 +1486,7 @@
>      import transform_sql
>      sql_sources = [
>        os.path.join('subversion', 'libsvn_fs_fs', 'rep-cache-db'),
> +      os.path.join('subversion', 'libsvn_fs_fs', 'revprops-db'),
>        os.path.join('subversion', 'libsvn_wc', 'wc-metadata'),
>        os.path.join('subversion', 'libsvn_wc', 'wc-checks'),
>        ]
> 


Reply via email to