On Nov 24, 2009, at 7:59 AM, Bert Huijben wrote: > Hi, > > One thing on moving the properties which I expected I wrote down but can't > find right now, is that we used to insert invalid property values in the > database in the previous WC-NG formats. > > > In several cases we store a blank value in the WORKING_NODE properties > column, where the value should have been NULL, to make some functions use > the BASE_NODE value. > > One example is the status base-deleted, where the 'pristine' version of the > properties should be retrieved from the BASE_NODE table. The > svn_wc__db_read_pristine_props() function would return an empty hashtable in > this case, where it should have returned the properties in BASE_NODE. > > I fixed the cases where we inserted the wrong values while adding the db > property update code, but before we move the properties I think we should > just set all properties columns to NULL.
Would this happen as part of the upgrade step? Actually, come to think of it, we could put a statement to set all the properties to NULL in wc-metadata.sql as part of the format 16 upgrade code. As stated before, I've got a working copy with the 'move props to the sqlite db' patch all ready to commit, it's just our upgrade system is broken, and I don't want to incur the wrath of dev@ by breaking everybody's working copies...again. :) > In other news: I'm still recovering from a middle ear infection in/behind my > right ear. > > Things are finally starting to get better and the ear proplems should be > resolved. I'm slowly increasing the amount of time I can spend on other > things until I have enough energy to return to work. (Currently I don't get > much further than answering a few mails at a time; but I'm glad my head is > clear enough to do some work again :( ) Yikes! Glad you're feeling better and don't feel like you need to push yourself for our account. There's plenty left to do on wc-ng. :) -Hyrum
