-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > Stefan Sperling wrote: >> The problem is that base has a trailing slash, so "/repos/svn/!svn/act/" >> is not considered canonical. [..] >> The old version canonicalised the URL while the new version does not: >> To fix this properly, we need to canonicalise the base somewhere. >> Please also check any other add_component->add_component2 upgrades >> made in r40202 for similar issues.
> Attached herewith is the patch which fixes the failing commit owing to > the above case. > > [[[ > Log: > Make a proper fix to resolve some deprecation warnings using > `svn_path_url_add_component2()' by canonicalizing the base before > passing to the above method; and a minor indentation fix. > > [in subversion/libsvn_ra_neon] > > * commit.c > (get_version_url, create_activity, commit_add_dir, commit_add_file > commit_close_file, add_child): Use `svn_path_url_add_component2()'. > (commit_delete_entry): Use `svn_path_url_add_component2()' and a minor > indentation fix in comment. > (svn_ra_neon__get_commit_editor, checkout_resource): Canonicalize the > base before passing to `svn_path_url_add_component2()'. > > * props.c > (svn_ra_neon__get_baseline_info): Canonicalize the base before passing > to `svn_path_url_add_component2()'. > > Patch by: Kannan R <kann...@collab.net> > ]]] Julian/Stefan: Ping? - -- Thanks & Regards, Kannan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEVAwUBSw95/nlTqcY7ytmIAQIZzwf/UC+USf1ILjSjsKGa8KbdvPUKq4ErvApp QpqKhM7Mis76gZULPOff8aIrjBFizgGo87hk9mFvD4BSFvVzAbXdy/h2As85InFQ CC8JJLJ8nqQKffb2LcGJD/r+C6eEeKYA/ELO7ZbM5DePzebywNG9NsYbCXN6qEdr 5McA78YawAw6FE08DQ1siRz5D0JesYiTcYto7Wq6PFpIFFkNQxon2MV48s+nb/IH dnpDCIU9q2FcqS5I28KxdLcBhlGbfLGAYlB/FWrGNzfrekA6ujZiIqyKuf1fqJ2j 1B9fuqyOmKMnwW6exYZCOGmKao0r3M5N69XA8inEGtZ5r8O0aHmkbA== =TPbk -----END PGP SIGNATURE-----
