On Dec 1, 2009, at 10:07 AM, Kannan wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > Log: > Resolve an unused variable warning, which shows up in solaris build[1]. > > * subverision/libsvn_delta/svndiff.c > (svn_txdelta_skip_svndiff_window): Remove the unused variable > `svndiff_version'. > > * subversion/include/svn_delta.h > (svn_txdelta_skip_svndiff_window): Same.
Whoa! This function is part of the public API. Unless it will be introduced in 1.7, it's name, behavior and arguments are considered immutable, and we can't go changing them on a whim (or ever, for that matter). > > * subversion/libsvn_fs_fs/fs_fs.c > (read_window): Same. > > Found by: bhuvan > Patch by: Kannan R <[email protected]> > > [1]-http://hudson.zones.apache.org/hudson/job/subversion-trunk-solaris/lastBuild/console > > - -- > Thanks & Regards, > Kannan > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iQEVAwUBSxU/XnlTqcY7ytmIAQLZpwf6Agk/O+TWzxYaM5OpVEYq7fDUq/fa8Y5B > LOvYMFFkdQORSAK5oxGVX8umqq8wDbp846TNL/b2ai4krVqcQGOxwvS1jB201ycX > Jxz6FK2DVlOGEg3cYX24RDjuHqCazZYpH+SRAXScmgEB8QBhP4ku+zX1S+XZGghL > jPhb7ilkSTFKjd/OCOKdIUrB225io5C6Bu0JLNyRY5DJIl4oxo9Krbj9vx/wNwVa > zS1d/pZZ2kFqlFhtjGemCZ5c2au03tK0fv7GrpB9ILKMYGOS19rf7WGgC4fRUsl0 > HWFKwOV4iaCz80wn7bSXzg2FbNLnQ6Y+LNbHR+9MgD2rXZg41RR6hw== > =8tfi > -----END PGP SIGNATURE----- > Index: subversion/libsvn_delta/svndiff.c > =================================================================== > --- subversion/libsvn_delta/svndiff.c (revision 885675) > +++ subversion/libsvn_delta/svndiff.c (working copy) > @@ -920,7 +920,6 @@ > > svn_error_t * > svn_txdelta_skip_svndiff_window(apr_file_t *file, > - int svndiff_version, > apr_pool_t *pool) > { > svn_stream_t *stream = svn_stream_from_aprfile2(file, TRUE, pool); > Index: subversion/include/svn_delta.h > =================================================================== > --- subversion/include/svn_delta.h (revision 885675) > +++ subversion/include/svn_delta.h (working copy) > @@ -516,7 +516,6 @@ > */ > svn_error_t * > svn_txdelta_skip_svndiff_window(apr_file_t *file, > - int svndiff_version, > apr_pool_t *pool); > > /** @} */ > Index: subversion/libsvn_fs_fs/fs_fs.c > =================================================================== > --- subversion/libsvn_fs_fs/fs_fs.c (revision 885675) > +++ subversion/libsvn_fs_fs/fs_fs.c (working copy) > @@ -3060,7 +3060,7 @@ > /* Skip windows to reach the current chunk if we aren't there yet. */ > while (rs->chunk_index < this_chunk) > { > - SVN_ERR(svn_txdelta_skip_svndiff_window(rs->file, rs->ver, pool)); > + SVN_ERR(svn_txdelta_skip_svndiff_window(rs->file, pool)); > rs->chunk_index++; > SVN_ERR(get_file_offset(&rs->off, rs->file, pool)); > if (rs->off >= rs->end)
