On Fri, 2009-12-04 at 12:36 +0000, Julian Foad wrote: > Bhuvaneswaran A wrote: > > Please find attached the revised patch. I incorporated following > > feedback: > > a) Fix the array slicing part > > b) Escape using ord() instead of removing those characters > > c) Handle "]]>" in CDATA section > > d) Define the ascii table globally (once) and re-use > > > > I also verified this fix by generating the junit files for tests having > > special characters and simulating a test that has "]]>" in failure text. > > With this patch, it generates valid junit file. > > It looks great. You could also move the definition of 'chars_to_remove' > out of the function, but either way it's fine. Go on, commit it!
Branko, Julian: Thank you for the review comments. Incorporated the above suggestion and committed in r887178. Now that the script is stable, as discussed in this thread [1], shall I nominate this script to 1.6.x branch? [1] http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410330 -- Bhuvaneswaran A CollabNet Software P Ltd. | www.collab.net
signature.asc
Description: This is a digitally signed message part
