-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Julian Foad wrote:
[..]
>
> Or late tonight, in fact.
>
> It's a good patch. Committed revision 887469.
>
> Thank you, Kannan.
>
> I think that fixed the last of the URLs being passed to
> svn_dirent_get_absolute(), so we can now assert that its input is not a
> URL.
Thank you. Seems the 'assert' is not yet moved to the repo, so sending
the patch herewith.
[[[
Log:
Assert on the input to `svn_dirent_get_absolute()'.
* subversion/libsvn_subr/dirent_uri.c
(svn_dirent_get_absolute): Add an assert statement to capture future
instances of calling this method on a URL.
Suggested by: julianfoad
Patch by: Kannan R <[email protected]>
]]]
- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEVAwUBSxyepnlTqcY7ytmIAQJRJggArGWJUu3n3ggyUtEVPzglp1jbAasE93vk
0MhuN2huFjKKUNzTFiOkOxI02v4bFc+csPNM0WTfMmr0A7x6uKrYAhIkxhBLkOsP
bfQL3opRmHC47F8wv+7Kr84A1PK4/HtYS+TgjyfIJSbbEzxl4rMbKoQwieSzVh6K
XEV/2QYG6lDO3xIlAo+wD+6q5oNZQSOoV69gXSeZSRyuDpOA4dFn28PezohgcWQN
Z+tR6FNba+hgAINZ92dt54HDf0KnmhxDN73ZzvRivUu1ZoYzPAZ3UvbObcFbT3Wc
i9wziaMNkkuCs0pMPWG8oMBSWHcM3ZsUd7mZ3pVAE2GQGKqZJgW0BA==
=/EP9
-----END PGP SIGNATURE-----
Index: subversion/libsvn_subr/dirent_uri.c
===================================================================
--- subversion/libsvn_subr/dirent_uri.c (revision 887843)
+++ subversion/libsvn_subr/dirent_uri.c (working copy)
@@ -1539,6 +1539,8 @@
char *buffer;
apr_status_t apr_err;
const char *path_apr;
+
+ SVN_ERR_ASSERT(!svn_path_is_url(relative));
/* Merge the current working directory with the relative dirent. */
SVN_ERR(svn_path_cstring_from_utf8(&path_apr, relative, pool));
