Hi Jon, I have logged your patch into the issue tracker: #3545 http://subversion.tigris.org/issues/show_bug.cgi?id=3545
Gavin On 28/11/2009, at 03:32 , Jon Foster wrote: > [Very sorry, my mailserver appears to be dropping attachments > and mangling inline patches by word-wrapping them. > Trying yet again, with patch as a ZIP file.] > > Hi, > > As discussed on this list, we don't always need svnsync's networked > lock. If svnsync only runs on a single server, the administrator > can use the "flock" tool to prevent running multiple copies of > svnsync at the same time. > > And if svnsync's lock is not needed, then it is actually an > inconvenience. E.g. if the network connection fails, then a stale > lock can be left behind. This requires manual administrator > intervention to fix. > > One workaround is for your scripts to run this command immediately > before they start svnsync: > svn propdel svn:sync-lock --revprop -r0 $target_url > > However, it would be better to provide a command-line option to > disable svnsync's locking. So, here's a patch to do that. > > The option name has been chosen to try to make it obvious that no > locking is a bad idea, and administrators should either use > svnsync's internal locking or have their own external locking. > > [[[ > Add --using-external-locking option to svnsync. > > * subversion/svnsync/main.c > (svnsync__opt): Add svnsync_opt_using_external_locking. > (SVNSYNC_OPTS_DEFAULT): Add svnsync_opt_using_external_locking. > (svnsync_options): Add entry for --using-external-locking. > (opt_baton_t): Add using_external_locking member. > (initialize_cmd, synchronize_cmd, copy_revprops_cmd): Don't take the > lock if using external locking. > (main): Handle svnsync_opt_using_external_locking option. > > Patch by: Jon Foster <jon.fos...@cabot.co.uk> > ]]] > > Kind regards, > > Jon > > > ********************************************************************** > This email and its attachments may be confidential and are intended solely > for the use of the individual to whom it is addressed. Any views or opinions > expressed are solely those of the author and do not necessarily represent > those of Cabot Communications Ltd. > > If you are not the intended recipient of this email and its attachments, you > must take no action based upon them, nor must you copy or show them to anyone. > > Cabot Communications Limited > Verona House, Filwood Road, Bristol BS16 3RY, UK > +44 (0) 1179584232 > > Co. Registered in England number 02817269 > > Please contact the sender if you believe you have received this email in > error. > > ********************************************************************** > > > ______________________________________________________________________ > This email has been scanned by the MessageLabs Email Security System. > For more information please visit http://www.messagelabs.com/email > ______________________________________________________________________<svnsync-external-locking.zip>
