On Tue, Jan 26, 2010 at 2:41 PM, Greg Stein <gst...@gmail.com> wrote: > On Tue, Jan 26, 2010 at 05:12, <i...@apache.org> wrote: >> Author: ivan >> Date: Tue Jan 26 10:12:05 2010 >> New Revision: 903153 >> >> URL: http://svn.apache.org/viewvc?rev=903153&view=rev >> Log: >> Follow up to r902836. >> >> * subversion/libsvn_ra_neon/util.c >> (wrapper_reader_cb): Use SVN_RA_NEON__REQ_ERR macro instead of >> assigning req->err directly to prevent potential error leakage. >> >> Modified: >> subversion/trunk/subversion/libsvn_ra_neon/util.c >> >> Modified: subversion/trunk/subversion/libsvn_ra_neon/util.c >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/util.c?rev=903153&r1=903152&r2=903153&view=diff >> ============================================================================== >> --- subversion/trunk/subversion/libsvn_ra_neon/util.c (original) >> +++ subversion/trunk/subversion/libsvn_ra_neon/util.c Tue Jan 26 10:12:05 >> 2010 >> @@ -1123,8 +1123,9 @@ >> if (parser_status) >> { >> /* Pass XML parser error. */ >> - pwb->req->err = check_parse_error(pwb->req->method, pwb->parser, >> - pwb->req->url); >> + SVN_RA_NEON__REQ_ERR >> + (pwb->req, check_parse_error(pwb->req->method, pwb->parser, >> + pwb->req->url)); > > There should be no white space before the function-call open paren. > Hi Greg,
Sorry I didn't understand what white space do you mean. There is no white spaces after SVN_RA_NEON__REQ_ERR macro and arguments are wrapped on next line. -- Ivan Zhakov VisualSVN Team
