On 02/15/2010 07:44 PM, Julian Foad wrote:
Kamesh Jayachandran wrote:
With the below apache configuration(See the trailing slash at the end of
'/svn/').
<Location /svn/>
DAV svn
SVNParentPath /repositories
SVNMasterURI http://master/svn/
SVNAdvertiseV2Protocol Off
</Location>
[...]
Attached patch fixes it.
This change came via fix for issue 3275. I believe this assertion is
just to clean the uri for double slash and not anything functional to
that issue, I may be wrong.
Thoughts?
The logic in your patch looks correct IF we accept that
dav_svn__get_root_dir() can return a non-canonical path. But if that's
the case, then we should document it as such:
[[[
Index: subversion/mod_dav_svn/dav_svn.h
===================================================================
--- subversion/mod_dav_svn/dav_svn.h (revision 910187)
+++ subversion/mod_dav_svn/dav_svn.h (working copy)
@@ -352,7 +352,7 @@
/* Return the activities db */
const char * dav_svn__get_activities_db(request_rec *r);
-/* Return the root directory */
+/* Return the root directory (not necessarily as a canonical path) */
const char * dav_svn__get_root_dir(request_rec *r);
]]]
or if it's meant to be canonical, then we should fix that function
instead.
May be that is the way to go, my setup is broken right now, will go in
this direction and commit.
Thanks for your review.
With regards
Kamesh Jayachandran
- Julian
