On 03/01/2010 02:46 PM, [email protected] wrote:
Author: hwright
Date: Mon Mar 1 22:46:45 2010
New Revision: 917772
URL: http://svn.apache.org/viewvc?rev=917772&view=rev
Log:
JavaHL: Return properties as byte[] throughout the callback interfaces.
We use byte[] in place of String because there could be binary data in the
property, and the conversion to String would truncate the property at any
NULL bytes.
Plus the conversion from byte[] to String depends upon the platform's
default character set.
I see there's a number of String's constructed from the byte[]. Those
methods should take an additional java.nio.charset.Charset and then pass
it's name to the String() constructor. I don't believe there should be
any String's constructed without a Charset argument.
Maybe the svn:date we can presume a UTF-8 character set, but the
svn:author, svn:log we shouldn't.
Regards,
Blair
