Thanks. FYI/FWIW:
In reality, check_wc2() shouldn't return a format number. Clients can do nothing with it. Best we can do is return a boolean saying "yes, this is a working copy". Today, TRUE corresponds to format>0. FALSE corresponds to format==0. transmit_text_deltas3() is just a poor design overall, not to mention the digest[] is drastically incorrect. These two functions (still) exist as quick-bumps to newer paradigms until they can be fully wiped out. Cheers, -g On Thu, Mar 4, 2010 at 07:11, <[email protected]> wrote: > Author: julianfoad > Date: Thu Mar 4 12:11:48 2010 > New Revision: 918960 > > URL: http://svn.apache.org/viewvc?rev=918960&view=rev > Log: > * subversion/include/svn_wc.h > (svn_wc_check_wc2, svn_wc_transmit_text_deltas3): Rename some arguments to > conform to standard patterns and to match the function definition. Fix > doc strings to match the argument names. > > Modified: > subversion/trunk/subversion/include/svn_wc.h > > Modified: subversion/trunk/subversion/include/svn_wc.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_wc.h?rev=918960&r1=918959&r2=918960&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_wc.h (original) > +++ subversion/trunk/subversion/include/svn_wc.h Thu Mar 4 12:11:48 2010 > @@ -2608,16 +2608,18 @@ > > /* Asking questions about a working copy. */ > > -/** Set @a *wc_format to @a path's working copy format version number if > - * @a path is a valid working copy directory, else set it to 0. > - * Return error @c APR_ENOENT if @a path does not exist at all. > +/** Set @a *wc_format to @a local_abspath's working copy format version > + * number if @a local_abspath is a valid working copy directory, else set it > + * to 0. > + * > + * Return error @c APR_ENOENT if @a local_abspath does not exist at all. > * > * @since New in 1.7. > */ > svn_error_t * > svn_wc_check_wc2(int *wc_format, > svn_wc_context_t *wc_ctx, > - const char *local_path, > + const char *local_abspath, > apr_pool_t *scratch_pool); > > /** > @@ -6431,7 +6433,7 @@ > /** > * Recurse from @a local_abspath, cleaning up unfinished log business. > Perform > * any temporary allocations in @a scratch_pool. Any working copy locks under > - * @a local_path will be taken over and then cleared by this function. > + * @a local_abspath will be taken over and then cleared by this function. > * > * WARNING: there is no mechanism that will protect locks that are still being > * used. > @@ -6914,7 +6916,7 @@ > svn_wc_transmit_text_deltas3(const char **tempfile, > unsigned char digest[], > svn_wc_context_t *wc_ctx, > - const char *local_path, > + const char *local_abspath, > svn_boolean_t fulltext, > const svn_delta_editor_t *editor, > void *file_baton, > > >
