Well, I know that you've expressed consternation at all the passing of the 
client context within libsvn_client.  I'm just wondering if that same sentiment 
extends to libsvn_wc as well. :)

-Hyrum


On Mar 28, 2010, at 8:30 AM, Greg Stein wrote:

> Simplify the call sites (the entire point!). eb is way shorter than the two
> de-refs. I did think about it tho, and settled with constifying eb.
> 
> I wouldn't be strongly opposed to changing it, but it would be significantly
> longer.
> 
> On Mar 27, 2010 9:46 PM, "Hyrum K. Wright" <hyrum_wri...@mail.utexas.edu>
> wrote:
> 
> 
> On Mar 27, 2010, at 6:04 PM, gst...@apache.org wrote:
> 
>> Author: gstein
>> Date: Sat Mar 27 23:04:28...
> Why pass the entire edit baton here?  You're only using the notify_func and
> notify_baton.
> 
> 
>> + const char *local_abspath,
>> + svn_node_kind_t kind,
>> + ...
> ...
> 
> -Hyrum

Reply via email to