Bert Huijben wrote: > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] >> Sent: dinsdag 6 april 2010 18:25 >> To: [email protected] >> Subject: svn commit: r931209 - >> /subversion/trunk/subversion/libsvn_ra/ra_loader.c >> >> Author: cmpilato >> Date: Tue Apr 6 16:25:21 2010 >> New Revision: 931209 >> >> URL: http://svn.apache.org/viewvc?rev=931209&view=rev >> Log: >> Add compat code to work around pre-1.7 servers' messy handling of >> mergeinfo paths. >> >> * subversion/libsvn_ra/ra_loader.c >> (svn_ra_get_mergeinfo): Strip leading slashes from catalog keys >> returned by the RA provider. > > Shouldn't we handle this in the specific RA layers instead of globally for > all ra-layers? > > That would allow removing the code for future code paths (like we did for > HTTPv2), while this code would hide the issues if we ever reintroduce the bug? > > I'm pretty sure you fixed ra_local, so that is at least one ra layer that > doesn't need this fix.
So, I made this change with 1.6.x in mind. 1.6.x benefits universally from this change because a) there's only codepath to debug if something is wrong, b) 1.6.x code will never be able to optimize out the correction (because we won't likely teach it to recognize newer servers), and c) I'm not proposing the server fix for 1.6.x. But sure, I can move the corrective behavior into specific RA layers for trunk. -- C. Michael Pilato <[email protected]> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
