On Fri, Apr 09, 2010 at 10:17:12PM +0200, Johan Corveleyn wrote:
> Hi devs,
> 
> Just a heads up, not really important, but I came across this in
> blame_cmd.c (inside print_line_info):
> 
> [[[
>   const char *rev_str = SVN_IS_VALID_REVNUM(revision)
>     ? apr_psprintf(pool, "%6ld", revision)
>                         : "     -";
> 
> ]]]
> 
> Which means that users of a repo with over 1 million revisions will
> see misaligned blame output ...
> 
> So I guess this is coming up for you guys when s.a.o reaches the 1
> million mark :-).

Nice buglet. I suppose we could simply add 2 or 3 spaces of indentation
until people run into even higher revisions in real life? :)

Stefan

Reply via email to