On Wed, Apr 21, 2010 at 05:09, Philip Martin <philip.mar...@wandisco.com> wrote: > Julian Foad <julian.f...@wandisco.com> writes: > >> COMPATIBILITY >> ============= >> >> We need to keep the old WC interface working: >> >> svn_wc_transmit_text_deltas2(&tempfile, &md5_digest, ...) >> svn_wc_queue_committed2(queue, path, ..., md5_checksum) >> svn_wc_process_committed_queue(queue, ...) >> >> How? I can't see a way to communicate the SHA-1 checksum to >> svn_wc_process_committed_queue() via the queue, but I can think of the >> following ways. > > There is an access baton in the old interface, it's opaque and can be > made to store anything. It could contain a hash of filename=>SHA-1.
Presumably, transmit_text_deltas2 is a wrapper around deltas3. Thus, deltas2 has the SHA1 value from that inner call. Putting something into *TEMPFILE is optional, so we can skip that. The MD5 result from deltas2 can be fetched from the PRISTINE table, given the SHA1 key. queue_committed2 can use the MD5 value and key into PRISTINE (we should have an index on PRISTINE.md5_checksum) to find the SHA1. This seems pretty straight-forward, unless I've missed something. (note that the pristine store would have this "extra" pristine, unreferenced by any other table; that could get garbage-cleaned by a separate process... BUT: there is an admin lock present during a commit, so we'd simply avoid GC'ing the PRISTINE table/on-disk) Cheers, -g
