Greg Stein <gst...@gmail.com> writes:

> With this change, our code no longer reads "all entries", nor does it
> attempt to cache that hash of entries.
>
> The only way to do so, is with svn_wc_entries_read(),
> svn_wc_walk_entries3(), or svn_wc_entry(). All three are deprecated
> and not used by trunk.
>
> Not seeing much of a performance gain, though. (I suspect SQLite
> caching was helping us before)
>
> Cheers,
> -g
>
> ps. this breaks special_tests 12 and stat_tests 5. I'll fix after sleep...

A lot more than that here, e.g. basic_tests 1, 2, 3, 4, 5, 6, 7, 8, 9,
10, 11, 12, 13, 14, 15, 16, 17, 23, 31, 32, 35, 38, 40 and 48 all
fail.  A typical failure is:

CMD: svn rm svn-test-work/working_copies/basic_tests-1/A/D/G --config-dir 
/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/config
 --password rayjandom --no-auth-cache --username jrandom
<TIME = 0.036079>
D         svn-test-work/working_copies/basic_tests-1/A/D/G/pi
D         svn-test-work/working_copies/basic_tests-1/A/D/G/rho
D         svn-test-work/working_copies/basic_tests-1/A/D/G/tau
D         svn-test-work/working_copies/basic_tests-1/A/D/G
CMD: svn status -v -u -q svn-test-work/working_copies/basic_tests-1 
--config-dir 
/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/config
 --password rayjandom --no-auth-cache --username jrandom
<TIME = 0.028362>
=============================================================
Expected '__SVN_ROOT_NODE' and actual '__SVN_ROOT_NODE' in status tree are 
different!
=============================================================
EXPECTED NODE TO BE:
=============================================================
 * Node name:   __SVN_ROOT_NODE
    Path:       __SVN_ROOT_NODE
    Contents:   N/A (node is a directory)
    Properties: {}
    Attributes: {}
    Children:   1
=============================================================
ACTUAL NODE FOUND:
=============================================================
 * Node name:   __SVN_ROOT_NODE
    Path:       __SVN_ROOT_NODE
    Contents:   None
    Properties: {}
    Attributes: {}
    Children:  None (node is probably a file)
Unequal Types: one Node is a file, the other is a directory



-- 
Philip

Reply via email to