Greg Stein wrote: > Yes, you hit the nail on the head. I had a similar concern, but wasn't > sure whether to bring it up. > > Specifically: in the particular case that *you* created the function > for, the copyfrom-fetching would most likely *never* be invoked. > node_get_url() should return a URL in almost every situation. In fact, > I started looking at get_url to delineate exactly *which* situations > it would not return a URL (that change is pending, but I'll quick > finish that and commit it for demonstration). > > But for other cases where you may have entry->copyfrom_*, then yes... > Philip's change is not going to be usable. > > I'll leave it for you to steer what kinds of query functions you need, > and I'll get this mod to node_get_url checked in.
I agree, it's probably okay in this case. But I think the docstring for svn_wc__node_get_copyfrom_info() needs to be updated to make its behavior clear. -- C. Michael Pilato <[email protected]> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
