> -----Original Message-----
> From: dan...@apache.org [mailto:dan...@apache.org]
> Sent: vrijdag 23 april 2010 21:12
> To: comm...@subversion.apache.org
> Subject: svn commit: r937475 -
> /subversion/trunk/subversion/libsvn_wc/util.c
>
> Author: dannas
> Date: Fri Apr 23 19:11:34 2010
> New Revision: 937475
>
> URL: http://svn.apache.org/viewvc?rev=937475&view=rev
> Log:
> * subversion/libsvn_wc/util.c
> (svn_wc__status2_from_3): Add note about the need to do a proper
> conversion instead of just a cast.
>
> Modified:
> subversion/trunk/subversion/libsvn_wc/util.c
>
> Modified: subversion/trunk/subversion/libsvn_wc/util.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/util
> .c?rev=937475&r1=937474&r2=937475&view=diff
> =======================================================================
> =======
> --- subversion/trunk/subversion/libsvn_wc/util.c (original)
> +++ subversion/trunk/subversion/libsvn_wc/util.c Fri Apr 23 19:11:34
> 2010
> @@ -548,5 +548,7 @@ svn_wc_status2_t *
> svn_wc__status2_from_3(const svn_wc_status3_t *status,
> apr_pool_t *scratch_pool)
> {
> + /* ### As of r937468, status2_t and status3_t are no longer
> identical. We
> + * ### need to extend this function to properly do the conversion.
> */
> return (svn_wc_status2_t *) svn_wc_dup_status3(status,
> scratch_pool);
> }
I think you should put some assertion in here instead of letting the caller
crash on invalid data. Or better yet, fix the conversion function while
changing the structure
The structures are unrelated now and you removed the best testcase for the
wrapper.
Bert
