On Wed, 2010-06-09 at 09:51 +0200, Stefan Sperling wrote: > On Wed, Jun 09, 2010 at 12:55:26PM +0530, Alexander Thomas wrote: > > [[[ > > Replace existing invalid propname to make test pass in Solaris. > > > > * subversion/tests/cmdline/prop_tests.py > > (invalid_propnames): Changed propname to empty char. > > ]]] > > > > > > -Alexander Thomas (AT) > > > Index: subversion/tests/cmdline/prop_tests.py > > =================================================================== > > --- subversion/tests/cmdline/prop_tests.py (revision 952911) > > +++ subversion/tests/cmdline/prop_tests.py (working copy) > > @@ -1420,7 +1420,7 @@ > > cwd = os.getcwd() > > os.chdir(wc_dir) > > > > - propname = chr(8) > > + propname = '' > > The test used to check for an unprintable ascii character (backspace). > With this patch, it checks for an empty string. > I'm not sure if this is a good thing to do. > I meant to use chr(32) and not an empty string. Subversion will treat propnames starting with space as invalid. Should I post another patch?
> In what way does chr(8) make this test fail on Solaris? prop commands errors with "svn: Non-ASCII character (code 8) detected, and unable to convert to/from UTF-8" in solaris. I tried different non-printable characters which resulted in same error. > Maybe we can find a better solution? > do you have anything in mind?
