On Sat, Jun 12, 2010 at 11:52 PM, Bert Huijben <b...@vmoo.com> wrote:
> > > > -----Original Message----- > > From: hwri...@apache.org [mailto:hwri...@apache.org] > > Sent: zaterdag 12 juni 2010 22:48 > > To: comm...@subversion.apache.org > > Subject: svn commit: r954136 - /subversion/trunk/build/run_tests.py > > > > Author: hwright > > Date: Sat Jun 12 20:48:17 2010 > > New Revision: 954136 > > > > URL: http://svn.apache.org/viewvc?rev=954136&view=rev > > Log: > > * build/run_tests.py > > (_run_test): Hopefully fix the windows tests by passing the correct > > arguments to subprocess.call(). > > > > Modified: > > subversion/trunk/build/run_tests.py > > > > Modified: subversion/trunk/build/run_tests.py > > URL: > > http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=95 > > 4136&r1=954135&r2=954136&view=diff > > ========================================================== > > ==================== > > --- subversion/trunk/build/run_tests.py (original) > > +++ subversion/trunk/build/run_tests.py Sat Jun 12 20:48:17 2010 > > @@ -345,7 +345,7 @@ class TestHarness: > > if self.log: > > os.dup2(self.log.fileno(), 1) > > os.dup2(self.log.fileno(), 2) > > - rv = subprocess.call(arglist) > > + rv = subprocess.call([progname] + arglist[1:]) > > Not sure why, but after this patch it seems that the applications only see > [progname] and not arglist. > > The real problem was that spawnv asked the program to quote the strings, > while subprocess handles the quoting for you. (And Windows can't find the > file '"somefile.py"' ). Fixed in r954143. > Thanks. I was sorry to break the windows tests, but figured you'd fix them in short order; I just didn't think it'd be *this* fast. :) -Hyrum
